search

atom / tabs

Tabs in Atom
MIT License
111 stars 118 forks source link

Allowed Locations & Permanent Dock Items #424

Closed matthewwithanm closed 7 years ago

matthewwithanm commented 7 years ago

These address the feedback in atom/atom#13977 by:

  1. Only adding the close icon for dock item when isPermanentDockItem() returns false (or is absent).
  2. Only allowing an item to be dropped into tab bars and panes if its getAllowedLocations() method includes the location (or is absent).

I updated layout to not show the overlay over disallowed locations. It would be nice to also change the cursor from copy to no-drop then too, but I couldn't find where this was being done.

matthewwithanm commented 7 years ago

(tabs are still closable via the context menu and commands)

maxbrunsfeld commented 7 years ago

👌