tabs toggles tree-view automatically w/ Atom focus

jm-gray commented 6 years ago

Prerequisites

[x ] Put an X between the brackets on this line if you have done all of the following:
- Reproduced the problem in Safe Mode: http://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
- Followed all applicable steps in the debugging guide: http://flight-manual.atom.io/hacking-atom/sections/debugging/
- Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
- Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
- Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description

The tree-view is toggled on when the Atom app gets focus. If I toggle tree-view off, then go to another app, then go back to Atom, it launches automatically. The same things happen when opening an existing file, or creating a new one from within Atom. Keyboard shortcuts for switching among tabs (Cmd+Shift+[ or ]) also no longer work. Disabling tree-view package does not work. Even with tree-view disabled, an empty Project pane will appear. Disabling tabs fixes these issues.

Steps to Reproduce

enable tabs package
open a file
toggle off tree-view if necessary
open an existing file, create a new file, or switch to another application and then switch back to Atom

Expected behavior: tree-view stays toggled off

Actual behavior: tree-view toggles on with most actions

Reproduces how often: 100%

Versions

Atom 1.19.3x64 macOS Sierra 10.12.6

Additional Information

Any additional information, configuration or data that might be necessary to reproduce the issue.

jm-gray commented 6 years ago

I'm surprised that no one else seems to report this issue w/ version 0.107.2

I rolled back to 0.106.2 and things are back to normal, so it's definitely something in the update that breaks on my system

Ben3eeE commented 6 years ago

/cc: @rsese

itsjoekent commented 6 years ago

I am on 0.107.1 and have been experiencing this issue consistently this week. ~@jm-gray I'm going to search around but in case I can't figure it out, how did you roll back to that version?~

EDIT: Here is the command for anyone that stumbles onto this apm install tabs@0.106.2

I can confirm this also fixed the problem for me as well

rsese commented 6 years ago

Thanks for the report! I was unable to reproduce with Atom 1.19.7 on macOS 10.12.6, here's what I tried:

Start Atom in safe mode atom --safe
Open a new window cmd-shift-n
Open a file cmd-o
Toggle off the tree view cmd-\
Create a new file cmd-n

The tree view didn't toggle back on at this point. I also tried cmd-tab-ing to another application and then back to Atom but the tree view remained toggled off.

Did I misunderstand anything about the repro steps @jm-gray?

jm-gray commented 6 years ago

@rsese interesting, I just upgraded to Atom 1.20.1x64, still on macOS 10.12.6, upgraded tabs to 0.107.4 and I still have the issue.

However, I DO NOT have the issue in safe mode. So, perhaps tabs isn't playing nicely with some other package. I don't have many packages installed, just Sublime-Style-Column-Selection, language-latexsimple, language-rmarkdown, language-r, r-exec, tabs, and wordcount in addition to the core packages.

Ben3eeE commented 6 years ago

@jm-gray It sounds like you have tabs installed as a community package in addition to it being installed as a core package.

If you open a terminal and run apm uninstall tabs does the problem go away? This will make you use the version that is bundled with Atom instead of the latest master version.

Ben3eeE commented 6 years ago

@rsese We should try the same steps on master to verify if this is a regression on master. Edit: And like check which version of tabs are in the released versions vs the ones reported as working here.

Ben3eeE commented 6 years ago

@jm-gray @itsjoekent Do you have Auto Reveal on in the tree-view package settings? This is known to happen when you have that option on /cc: https://github.com/atom/tree-view/issues/796

Is there any setting in tabs or tree-view that changes the behavior if you toggle it and try the same steps?

Ben3eeE commented 6 years ago

Thank you for your issue!

We haven't gotten a response to our questions in our comments https://github.com/atom/tabs/issues/517#issuecomment-331961228 https://github.com/atom/tabs/issues/517#issuecomment-331883877. With only the information that is currently in the issue, we don't have enough information to take action. I'm going to close this but don't hesitate to reach out if you have or find the answers we need, we'll be happy to reopen the issue.

atom / tabs