Don't create a split if the tab cannot be placed in the pane

atom / tabs

Tabs in Atom

MIT License

111 stars 115 forks source link

Don't create a split if the tab cannot be placed in the pane #550

Closed 50Wliu closed 5 years ago

50Wliu commented 5 years ago

This fixes a regression from #548. The code there was toPane ? target, even though toPane was always undefined. I mistakenly moved the location check to after toPane's definition, even though we should always be able to look at target (as a split will not affect the pane's location).