Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
All new code requires tests to ensure against regressions
Description of the Change
It really wasn't clear what these tests were doing before, which was partly because the width of each tab was not explicitly defined. The tests themselves were also wrong - scrollIntoView doesn't do anything if the item is at least partially visible. I've updated these tests to properly test that scrolling works as expected, and also updated scrollIntoView to use the new options listed at https://developer.mozilla.org/en-US/docs/Web/API/Element/scrollIntoView.
Alternate Designs
None.
Benefits
The purpose of these tests should be more clear and the intended behavior more easy to follow.
Requirements
Description of the Change
It really wasn't clear what these tests were doing before, which was partly because the width of each tab was not explicitly defined. The tests themselves were also wrong -
scrollIntoView
doesn't do anything if the item is at least partially visible. I've updated these tests to properly test that scrolling works as expected, and also updatedscrollIntoView
to use the new options listed at https://developer.mozilla.org/en-US/docs/Web/API/Element/scrollIntoView.Alternate Designs
None.
Benefits
The purpose of these tests should be more clear and the intended behavior more easy to follow.
Possible Drawbacks
None.
Applicable Issues
None.