Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
All new code requires tests to ensure against regressions
Description of the Change
The method signature for IPC callbacks is (event, args...), but the tabs package was using (args...) instead. This meant that when dropping a tab onto another Atom window, the original tab would never be destroyed as intended.
Alternate Designs
None.
Benefits
This fixes a long-standing bug with dropping tabs on other windows, which was not discovered by the tests as they called the callback manually.
Possible Drawbacks
The specs are a little hacky...since the listener callback is binded, it's almost impossible to spy on it correctly. So I resorted to spying on a function that the callback calls.
Requirements
Description of the Change
The method signature for IPC callbacks is
(event, args...), but the tabs package was using(args...)instead. This meant that when dropping a tab onto another Atom window, the original tab would never be destroyed as intended.Alternate Designs
None.
Benefits
This fixes a long-standing bug with dropping tabs on other windows, which was not discovered by the tests as they called the callback manually.
Possible Drawbacks
The specs are a little hacky...since the listener callback is
binded, it's almost impossible to spy on it correctly. So I resorted to spying on a function that the callback calls.Applicable Issues
None.