atom / telemetry

sends usage metrics to GitHub's internal analytics pipeline
MIT License
11 stars 12 forks source link

pass the gitHubUser field to the metrics pipeline #17

Closed annthurium closed 6 years ago

annthurium commented 6 years ago

Description of the Change

If a user has authenticated, pass their username along with metrics requests to the back end.

Implementation

The StatsStore is instantiated in the atom metrics package. metrics doesn't know what the GitHub username is, nor should it. The GitHub package is the only package where this info is available. Therefore, the StatsStore needs to have a method exposed to set the gitHubUser. If the GitHub username has been set, that value is then passed along when daily metrics are sent to the internal analytics pipeline. If the gitHubUser has not been set, a null value is passed along instead.

Test plan

Future work