search

atom / telemetry

sends usage metrics to GitHub's internal analytics pipeline
MIT License
11 stars 12 forks source link

Enable Travis CI #4

Closed smashwilson closed 6 years ago

smashwilson commented 6 years ago

Let's get Travis up and running, and try out their new checks API integration while we're at it :sparkles:

annthurium commented 6 years ago

thank you @smashwilson !!!

annthurium commented 6 years ago

can we set it up so that it run npm run lint in addition to the unit tests?

smashwilson commented 6 years ago

can we set it up so that it run npm run lint in addition to the unit tests?

On it 👍 I can do that in one of two ways:

  1. Add an explicit npm run lint step to the Travis build; or
  2. Modify package.json to run the linter every time npm test is run, so Travis will pick it up as part of the default build.

The advantage of (2) is that you'd lint when you run npm test locally, too (and you could still run a non-linting test with something like npm run mocha).

Which would you prefer?

annthurium commented 6 years ago

@smashwilson I think #2 sounds better. thank you!

smashwilson commented 6 years ago

Looks like npm ci wasn't added until after npm 5.5.1. (npm ci uses package-lock.json as a source of truth instead of package.json, so it is (a) more consistent and (b) super fast). Not a big deal, we can add it in later as things get upgraded.

annthurium commented 6 years ago

🚢 it!