actually send the stats at the specified interval

atom / telemetry

sends usage metrics to GitHub's internal analytics pipeline

MIT License

11 stars 12 forks source link

actually send the stats at the specified interval #9

Closed annthurium closed 6 years ago

annthurium commented 6 years ago

Use a setInterval loop to periodically check if we need to send stats. This loop is automatically set up when the store is instantiated, because I thought it would be nicer for clients of this package to not have to deal with setting up timers and such.
add unit tests for the timer, and for the shouldReportDailyStats method

annthurium commented 6 years ago

It seems like there is this tension in general between "keep everything private so it's clear to callers of this package what the api is" and "make things public so they can be testable." I don't know how to resolve that.