atom / teletype

Share your workspace with team members and collaborate on code in real time in Atom
https://teletype.atom.io
MIT License
2.41k stars 324 forks source link

Add libdbus-1-3 dependency for Electron 3 builds of Atom #437

Closed daviwil closed 2 years ago

daviwil commented 5 years ago

Description of the Change

Latest Teletype master builds on Travis CI against Atom Dev are failing with a renderer crash. One obvious starting point is this error that gets written out in the dev build log:

/home/travis/atom/usr/share/atom-dev/atom: /lib/x86_64-linux-gnu/libdbus-1.so.3: no version information available (required by /home/travis/atom/usr/share/atom-dev/atom)

This change adds libdbus-1-3 to the apt-get install call to ensure that this dependency exists on the CI machine.

Alternate Designs

None at the moment, let's see if this fixes the issue.

Benefits

Passing dev builds on master.

Possible Drawbacks

None.

Verification Process

Applicable Issues

None.

daviwil commented 5 years ago

This error is a red herring and isn't a cause for concern: https://github.com/electron/electron/issues/16364.

Continuing to investigate...