atom / teletype

Share your workspace with team members and collaborate on code in real time in Atom
https://teletype.atom.io
MIT License
2.41k stars 322 forks source link

Fix renderer crash issue in PortalListComponent test in Electron 3.0 #438

Closed daviwil closed 5 years ago

daviwil commented 5 years ago

Description

It seems that there's an issue with window.fetch in Atom, built on Electron 3.0, which causes a renderer process crash in the "PortalListComponent initialization" test when TeletypeClient.initialize gets called. I've tracked this down to the usage of window.fetch inside of teletype-client's RestGateway.fetch method. This problem doesn't occur when Atom is built with Electron 2.0 and below.

Strangely, I'm able to use Teletype with no issues inside of Atom so I suspect that this might be an issue with how Teletype's tests are configured and executed.

Steps to Reproduce

  1. Download an Atom Dev build or build it from master
  2. Follow steps in README.md to clone Teletype package and set up test DB
  3. Run atom --test test in the teletype repo folder (use the Atom Dev build for this)
  4. Observe renderer process crash at the "PortalListComponent initialization" test
rafeca commented 5 years ago

Fixed by https://github.com/atom/teletype/pull/453