Failing build on Dev channel

atom / teletype

Share your workspace with team members and collaborate on code in real time in Atom

https://teletype.atom.io

MIT License

2.41k stars 322 forks source link

Failing build on Dev channel #515

Closed darangi closed 4 years ago

darangi commented 4 years ago

Description of the Change

The dev channel on the CI currently fails, this is because it tries to build on atom's master branch which uses electron 5. Electron 5's API has a slight change in the values used in making the tests assertions. This PR helps to conditionally implement the assertions based on the channel the CI is using.

fixes https://github.com/atom/teletype/issues/514

lkashef commented 4 years ago

elegant 👍 love it, let's merge it in!