search

atom / toggle-quotes

An Atom package to toggle between single and double quotes
MIT License
77 stars 36 forks source link

Was working fine, now nothing happens.... #46

Open mattbryson opened 7 years ago

mattbryson commented 7 years ago

Whats the easiest way to debug this?

Plugin was working fine until recently - I have upgraded atom and installed other plugins, so it could be anything - have tried disabling other plugins but still no joy.

But nothing else has the keybinding....

Any pointers in how to debug?

aendra-rininsland commented 7 years ago

I'm experiencing this as well, using the Babel ES6 grammar. Switching to the standard JavaScript grammar solves the issue.

rsese commented 7 years ago

@mattbryson - can you share some sample content where this doesn't work for you and which grammar you're using?

aendra-rininsland commented 7 years ago

Bizarrely, now it's working on the Babel ES6 Grammar as well — possibly I've updated since then? Sorry I'm not much help here in narrowing down the cause; if I run into it again I'll try to debug it more in-depth.

mattbryson commented 7 years ago

@rsese Its failing for all grammars (I was mainly using it on JS / PHP).

Just this simple JS file

function test () { return "hello"; }

Clicking in the double quotes and hitting cmd + " does nothing.

Atom 1.15.0 OSX 10.12.3

I have disabled all my community packages, bar toggle-quotes

screen shot 2017-03-21 at 11 13 09

screen shot 2017-03-21 at 11 12 47

Is there a log file that would be any help?

rsese commented 7 years ago

Just this simple JS file

function test () { return "hello"; }

Clicking in the double quotes and hitting cmd + " does nothing.

Thanks for the details, I just gave this a try and it worked for me with a new file and choosing JavaScript as the language.

Is there a log file that would be any help?

Hmmm, I think you might have referenced it earlier but to confirm, did you use the keybinding resolver to double check that toggle-quotes:toggle is getting called?

Also, does quote toggling work if you use Toggle Quotes: Toggle from the command palette?

ujLion commented 6 years ago

Shortcut has changed to: { ctrl + shift + ' }

senki commented 6 years ago

I recently ran into this issue. In my case in .php the toggle is working but in .js is not. I figured out the problem for me is the enabled "Tree Sitter Parser" setting if I disable it the toggle works in Javascript too.

Hope helps to others

jasonrudolph commented 6 years ago

I recently ran into this issue. In my case in .php the toggle is working but in .js is not. I figured out the problem for me is the enabled "Tree Sitter Parser" setting if I disable it the toggle works in Javascript too.

/fyi @maxbrunsfeld