search

atom / toggle-quotes

An Atom package to toggle between single and double quotes
MIT License
77 stars 36 forks source link

Toggle stops with backtick #51

Closed slyy closed 6 years ago

slyy commented 7 years ago

I have added backtick alongside single quote & double-quote (ha! Javascript devs ;))

When I toggle now, it goes " => ' => ` then it stops and does not toggle anymore.

slyy commented 7 years ago

Mentioned in https://github.com/atom/toggle-quotes/issues/35

mattyclarkson commented 6 years ago

I have exactly the same issue, but #35 says that it is fixed.

Ben3eeE commented 6 years ago

@mattyclarkson From what I understand this happens when the quote character you toggle to is not recognized by the language.

https://github.com/atom/toggle-quotes/pull/45 looks like it's aiming to fix this.

pdxwolfy commented 6 years ago

Broken for me in JavaScript - it stops cycling at backticks.

pdxwolfy commented 6 years ago

This works under 1.1.3 now; thanks!

Ben3eeE commented 6 years ago

This was fixed by @savetheclocktower

softwarecreations commented 4 years ago

This issue is not fixed. It's still present in 1.1.4 as of 2020-03-13.

The fact that we can now define custom ticks by filetype is a slight help but not really. For example PHP files can embed Githubissues.

  • Githubissues is a development platform for aggregating issues.