atom / tree-view

🌳 Explore and open project files in Atom
MIT License
561 stars 364 forks source link

Junction (hardlink) in git repository showing as modified #1018

Open mattheyan opened 7 years ago

mattheyan commented 7 years ago

Prerequisites

Description

https://discuss.atom.io/t/junction-hardlink-in-git-repository-showing-as-modified/37761/3

I created junctions in my repository so that the files can live elsewhere, which seems to work just fine on the git side. But, the Atom tree-view is showing the directory/files as changed even though the git repository reports no changes. Any ideas why this might be? I've tried restarting the editor but that doesn't fix it.

Steps to Reproduce

  1. Create a git repository with clean state
    • mkdir AtomTest
    • cd AtomTest
    • echo "Testing..." > Readme.txt
    • git init
    • git add .
    • git commit -m "Initial commit"
  2. Create a junction within the git repository, and commit its contents
    • mklink /J C:\Path\To\AtomTest\Subfolder C:\Some\Other\Folder
    • git add .
    • git commit -m "Add subfolder"

Expected behavior: Atom should show no pending modifications in the tree view.

Actual behavior: The junction folder and all of its contents appear as modified

Reproduces how often: Always

Versions

Windows 8.1 Enterprise

Atom : 1.12.9 Electron: 1.3.13 Chrome : 52.0.2743.82 Node : 6.5.0

apm 1.12.9 npm 3.10.5 node 4.4.5 python 2.7.10 git 2.10.2.windows.1 visual studio 2015

lee-dohm commented 7 years ago

@ungb Do you have time to take a look at this?

ungb commented 7 years ago

I can repro this on windows:

in Atom(1.13.0) after following the steps image

on cmd line: image

ungb commented 7 years ago

on windows if you run the following batch script(zipped up) it will open atom in this scenario.

createIssue1018Repro.zip

cshaa commented 7 years ago

I was unable to +1 this, so just reporting: this happenes to me too. Windows 10, Atom 1.14.1