atom / tree-view

🌳 Explore and open project files in Atom
MIT License
560 stars 365 forks source link

Files appear as if they have uncommitted changes in tree #1240

Open MRossol opened 6 years ago

MRossol commented 6 years ago

Prerequisites

Description

Files are appearing as if they have uncommitted changes in the tree, but the project is up to date:

screen shot 2018-03-28 at 7 55 51 pm

The problem has been getting progressively worse with more and more files not registering as up to date.

Steps to Reproduce

  1. Tried Safemode
  2. Tried removing the window state
  3. Tried a factory reset (screen shot is after this step)

Expected behavior: [What you expect to happen]

Files revert to grey in the tree after changes have been committed and pushed.

Actual behavior: [What actually happens]

Some files (no apparent pattern) do not revert to grey, others randomly change to yellow/orange despite being unchanged

Reproduces how often: [What percentage of the time does it reproduce?] The problem so far is unique to this project/directory/repository, but occurs 100% of the time when the project is opened in atom

Versions

Atom : 1.25.0 Electron: 1.7.11 Chrome : 58.0.3029.110 Node : 7.9.0

apm 1.19.0 npm 3.10.10 node 6.9.5 x64 atom 1.25.0 python 3.6.4 git 2.10.1

Mac OS 10.12.6

You can get this information from copy and pasting the output of atom --version and apm --version from the command line. Also, please include the OS and what version of the OS you're running.

Additional Information

Any additional information, configuration or data that might be necessary to reproduce the issue.

rsese commented 6 years ago

Thanks for the report - would you be able to share the project itself or a small public test project based on the files/directories showing this behavior that we can try?

Is there any interesting about the files that are showing as modified? E.g. do the files have accented characters in their file names?

MRossol commented 6 years ago

Hi Robert,

Sorry for the long delay, I've yet to be able to rectify the problem. I originally thought it was an issue with duplicate file names in multiple subdirectories and tried cleaning up the redundancy to no avail.

I've copied over one of the problematic folders to a new repo: https://github.com/MRossol/atom_tree_test

The problem persists even when copying the files.

Thanks for the help and let me know if I can do anything else on my end. -Michael

On Thu, Mar 29, 2018 at 12:02 AM Robert Sese notifications@github.com wrote:

Thanks for the report - would you be able to share the project itself or a small public test project based on the files/directories showing this behavior that we can try?

Is there any interesting about the files that are showing as modified? E.g. do the files have accented characters in their file names?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/atom/tree-view/issues/1240#issuecomment-377131063, or mute the thread https://github.com/notifications/unsubscribe-auth/ARyIq06pns_UyfRZ0oHSzu4-4_noSss-ks5tjHjpgaJpZM4S_oaT .

thomasjo commented 6 years ago

@MRossol Have you tried executing git status from a terminal? Does the output you see there match what you're seeing in Atom?

MRossol commented 6 years ago

It does not match. The files that appear to have uncommitted changes in atom do not show up when executing git status:

mrossol-29709s:WRF_and_WTK mrossol$ git status On branch master Your branch is up-to-date with 'origin/master'. nothing to commit, working tree clean

[image: Screen Shot 2018-04-17 at 11.50.57 AM.png]

On Tue, Apr 17, 2018 at 11:43 AM Thomas Johansen notifications@github.com wrote:

@MRossol https://github.com/MRossol Have you tried executing git status from a terminal? Does the output you see there match what you're seeing in Atom?

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/atom/tree-view/issues/1240#issuecomment-382080548, or mute the thread https://github.com/notifications/unsubscribe-auth/ARyIq1epOB4DZ2575U8iLFHTfWFV1-EWks5tpimjgaJpZM4S_oaT .

thomasjo commented 6 years ago

@MRossol Thanks for checking! Unfortunately I don't really know what might be causing this then.

MRossol commented 6 years ago

No worries, thanks for the help. A few updates: 1) If I delete the local repo and clone a fresh copy the problem disappears (so far). 2) By best guess is that the problem is due to redundant file names across sub-directories (an unfortunate necessity in the workflow)

At least I have a workaround for now...

On Tue, Apr 17, 2018 at 11:55 AM Thomas Johansen notifications@github.com wrote:

@MRossol https://github.com/MRossol Thanks for checking! Unfortunately I don't really know what might be causing this then.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/atom/tree-view/issues/1240#issuecomment-382084593, or mute the thread https://github.com/notifications/unsubscribe-auth/ARyIqzPTakMViFqbZWpm4Tzk-1omsR1Mks5tpiyQgaJpZM4S_oaT .

Arcanemagus commented 6 years ago

Expected behavior: Files revert to grey in the tree after changes have been committed and pushed.

Grey color is actually the color for ignored files, it sounds like you have a rather odd repository configuration but it looks like you've deleted the example repository so I can't check on it.

mattcollier commented 5 years ago

I've been seeing this same issue since I put in this issue for v1.27: https://github.com/atom/atom/issues/17352

I was hoping this would just go away, but it still persists for me in v1.30.0.

Debian 10 Buster (testing)

atom --version Atom : 1.30.0 Electron: 2.0.5 Chrome : 61.0.3163.100 Node : 8.9.3

apm --version apm 1.19.0 npm 3.10.10 node 6.9.5 x64 atom 1.30.0 python 2.7.15 git 2.18.0

In the past couple days I have

Nothing has changed. The UI still shows highlighting on the committed files until I make the Atom window lose focus and regain focus. Usually I do this by an Alt-Tab.

tracking: https://github.com/atom/atom/issues/17994

mattcollier commented 5 years ago

This is not just affecting the document list in tree-view, the git-diff indicators in the document are not updated either.

shadow-light commented 5 years ago

Same here. So this doesn't happen for everyone?

Ubuntu 16.04 Atom 1.30.0 Electron 2.0.5 Chrome: 61.0.3163.100 Node: v8.9.3

mattcollier commented 5 years ago

@shadow-light thank you for connecting the dots! For a year now I've been thinking I was the only one experiencing this issue.

tvld commented 5 years ago

ubuntu 18.04 Have same issue after renaming my module.

tvld commented 5 years ago

Seems I solved it for myself by first removing the repo as submodule from ./.git/modules and the config file there. And then:

git submodule init  <reponame>
git submodule update <reponame>