Re-implements hiding behavior based on promise to fix timing error.

atom / tree-view

🌳 Explore and open project files in Atom

MIT License

561 stars 364 forks source link

Re-implements hiding behavior based on promise to fix timing error. #1396

Closed joaotmartins closed 2 years ago

joaotmartins commented 3 years ago

Description of the Change

Re-implemented hiding code to perform conditional hiding as a callback of treeViewOpenPromise. This fixes an error where we might have attempted to hide the pane before it existed (usually only happened when Atom was started up with a clean profile).

Alternate Designs

None.

Benefits

Tree-view hiding works even when there are a few timing differences in the pane initialization.

Possible Drawbacks

None.

Applicable Issues

See comments to atom/tree-view#1389

joaotmartins commented 3 years ago

Fixes the original implementation for #1370 and #1375 .

pokono commented 2 years ago

Any progress on this? 😭