search

atom / watcher

Atom Filesystem Watcher
MIT License
200 stars 36 forks source link

An in-range update of nan is breaking the build 🚨 #194

Closed greenkeeper[bot] closed 5 years ago

greenkeeper[bot] commented 5 years ago

The dependency nan was updated from 2.11.1 to 2.12.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

nan is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details - ✅ **continuous-integration/travis-ci/push:** The Travis CI build passed ([Details](https://travis-ci.org/atom/watcher/builds/468645972?utm_source=github_status&utm_medium=notification)). - ✅ **continuous-integration/appveyor/branch:** AppVeyor build succeeded ([Details](https://ci.appveyor.com/project/Atom/watcher/builds/21043722)). - ❌ **ci/circleci:** Your tests failed on CircleCI ([Details](https://circleci.com/gh/atom/watcher/626?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link)).
Commits

The new version differs by 11 commits.

  • e8f8519 2.12.0
  • 55923c8 Prepare for 2.12.0
  • 8883bed add node.js version 11 (#830)
  • e222068 Fix deprecation warnings in test suite.
  • 509859c Fix Node.js v10.12.0 deprecation warnings.
  • e6ef6a4 Allow SetWeak() for non-object persistent handles. (#824)
  • 801f129 doc: fix link
  • 02888e1 Drop Node.js v0.8.x from Travis CI.
  • 0c95010 [doc] fix links and a few copy paste errors (#816)
  • 2e5ed4f Add scope.Escape() to Call() (#817)
  • 3736dd1 add nan-*.tgz to .npmignore (#818)

See the full diff

FAQ and help There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).

Your Greenkeeper Bot :palm_tree:

greenkeeper[bot] commented 5 years ago

After pinning to 2.11.1 your tests are still failing. The reported issue might not affect your project. These imprecisions are caused by inconsistent test results.

greenkeeper[bot] commented 5 years ago

Your tests are still failing with this version. Compare changes

Commits

The new version differs by 3 commits.

  • 1b77c11 2.12.1
  • 4c354e1 Prepare for 2.12.1
  • 625e90e Fix build breakage with Node.js 10.0.0-10.9.0. (#833)

See the full diff