search

atom / watcher

Atom Filesystem Watcher
MIT License
200 stars 36 forks source link

Update syntax to build against electron v7.3.2 #236

Closed taratatach closed 3 years ago

taratatach commented 4 years ago

Description of the Change

Electron 7.3.2 brings in NodeJS v12.8.1 which requires to update some Nan function calls.

We now pass the current Local<Context> to Object->Set() calls and all methods extending it.

Benefits

Atom/Watcher can now be built against electron v7.3.2.

aminya commented 4 years ago

@taratatach Is this ready? I am not sure what is up with the CI.

taratatach commented 4 years ago

@aminya I haven't had a chance to test it in an Electron 7 application yet as I have other dependencies to upgrade in the same way but tests are passing on AppVeyor and on my local linux laptop.

I don't know what's going on with the CI either I thought maybe this is because I'm not a project maintainer so that my PR won't be built?

taratatach commented 4 years ago

Hi @lkashef, is there anything I can do to help move this PR forward?

taratatach commented 3 years ago

Work done again in #238.