Closed taratatach closed 3 years ago
@taratatach Is this ready? I am not sure what is up with the CI.
@aminya I haven't had a chance to test it in an Electron 7 application yet as I have other dependencies to upgrade in the same way but tests are passing on AppVeyor and on my local linux laptop.
I don't know what's going on with the CI either I thought maybe this is because I'm not a project maintainer so that my PR won't be built?
Hi @lkashef, is there anything I can do to help move this PR forward?
Work done again in #238.
Description of the Change
Electron 7.3.2 brings in NodeJS v12.8.1 which requires to update some
Nan
function calls.We now pass the current
Local<Context>
toObject->Set()
calls and all methods extending it.Benefits
Atom/Watcher can now be built against electron v7.3.2.