'Macintosh' key added to rules for iPad Pro

atomantic / is-ua-webview

📱tiny/simple npm module for detecting webview status of a user-agent

ISC License

58 stars 7 forks source link

'Macintosh' key added to rules for iPad Pro #9

Closed emrahyumuk closed 4 years ago

pierre-b commented 4 years ago

This commit is matching a DESKTOP Firefox on Mac OS... Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:76.0) Gecko/20100101 Firefox/76.0

pierre-b commented 4 years ago

I would recommend to exclude desktop user agents before applying the rules.

atomantic commented 4 years ago

Added that user agent as a test and reverted, pushed to npm as 1.0.4. Since I'm no longer the owner of the production service I was using this lib for (as a dataflag in logging service), I'm unlikely to make many updates here. The tests are sparse. If someone is interested in adding more test cases, I'll pull them in, but I'm going to plan on leaving this module in the current state for now.