search

atomantic / jquery.imgExplosion

💥Firework explosion of an image, optionally rotating into the screen in variable sizes and exploding at the end. w00t.
http://atomantic.github.com/jquery.imgExplosion
13 stars 2 forks source link

Great Plugin small issue #1

Closed gubagu closed 13 years ago

gubagu commented 13 years ago

First awesome Plugin !!!

Small issue: It does not work in IE 7 & 8 "Webpage error details

User Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 6.1; Trident/4.0; SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0; .NET CLR 1.1.4322; .NET CLR 3.5.21022; Media Center PC 5.0; SLCC1; Tablet PC 2.0; .NET4.0C; AskTbMYC/5.8.0.12304) Timestamp: Wed, 23 Mar 2011 14:03:09 UTC

Message: Object doesn't support this property or method Line: 137 Char: 222 Code: 0 URI: http://ajax.googleapis.com/ajax/libs/jquery/1.4.2/jquery.min.js"

I hope error info is useful

and the animation is kind of slow in FF 3.6.15

Take care and keep up the great work

Cheerz, Goby

atomantic commented 13 years ago

Thanks for the feedback and the bug report.

I took a look and apparently the syntax highlighting script used to display the code in the demo was throwing out some eval code that was being triggered in the explosion process. Rather than spend time further debugging it, I went ahead and removed the syntax highlighting from the demo (since it really isn't important). I also upgraded the reference to jquery to use 1.5.1--just to stay awesome.

Thanks!

gubagu commented 13 years ago

You're more than welcome ! Great Man! I have like 1000 ideas what to do with it :-D

Take care, Guby

atomantic commented 13 years ago

Right on. Oh, and for the performance stuff, just play around with the settings. The jquery.ui explosion effect actually is quite heavy--as is the rotate. You can also play with increasing the interval between throws (so there isn't so much animation happening at once). I built it for a single use firework sort of effect so once I got it tailored for my instance, I stopped playing with the settings :)

gubagu commented 13 years ago

Thanks for the tip