atomec-project / atoMEC

Python-based average-atom code for simulations of high energy density phenomena such as in warm dense matter.
https://atomec-project.github.io/atoMEC/
BSD 3-Clause "New" or "Revised" License
17 stars 12 forks source link

Update actions/environments to recent versions: #171

Closed DanielKotik closed 1 year ago

DanielKotik commented 1 year ago

Update workflow files to avoid using features and environments that will soon become deprecated.

DanielKotik commented 1 year ago

The tests fail due to an installation issue:

image

It seems that pipenv is using Python 3.10 instead of Python 3.8. Not yet sure why...

codecov[bot] commented 1 year ago

Codecov Report

Merging #171 (6c1116f) into develop (ccb0898) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #171   +/-   ##
========================================
  Coverage    97.62%   97.62%           
========================================
  Files           14       14           
  Lines         2191     2191           
========================================
  Hits          2139     2139           
  Misses          52       52           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

DanielKotik commented 1 year ago

The tests fail due to an installation issue:

image

It seems that pipenv is using Python 3.10 instead of Python 3.8. Not yet sure why...

Fixed.

timcallow commented 1 year ago

The tests fail due to an installation issue:

image

It seems that pipenv is using Python 3.10 instead of Python 3.8. Not yet sure why...

Maybe just because Ubuntu 22.04 uses Python 3.10 by default

DanielKotik commented 1 year ago

The tests fail due to an installation issue: image It seems that pipenv is using Python 3.10 instead of Python 3.8. Not yet sure why...

Maybe just because Ubuntu 22.04 uses Python 3.10 by default

Yes, you are right. Nevertheless, this confuses me because the README of action setup-python says:

This action provides the following functionality for GitHub Actions users:

  • Installing a version of Python or PyPy and (by default) adding it to the PATH
  • Optionally caching dependencies for pip, pipenv and poetry

I get around this problem by explicitly specifying the python version to use along with pipenv...