atomec-project / atoMEC

Python-based average-atom code for simulations of high energy density phenomena such as in warm dense matter.
https://atomec-project.github.io/atoMEC/
BSD 3-Clause "New" or "Revised" License
17 stars 12 forks source link

Remove config.fp option for float precision #200

Closed timcallow closed 1 year ago

timcallow commented 1 year ago

This feature should not have been added to the dev branch, after all things considered. It is too unstable and, with the improvements to the code, no longer particularly useful.

This PR removes the option for the user to use float32 precision.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 98.18% and project coverage change: -0.09% :warning:

Comparison is base (573b607) 91.64% compared to head (db3e527) 91.56%.

:exclamation: Current head db3e527 differs from pull request most recent head afcb0eb. Consider uploading reports for the commit afcb0eb to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #200 +/- ## =========================================== - Coverage 91.64% 91.56% -0.09% =========================================== Files 14 14 Lines 2419 2396 -23 =========================================== - Hits 2217 2194 -23 Misses 202 202 ``` | [Files Changed](https://app.codecov.io/gh/atomec-project/atoMEC/pull/200?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=atomec-project) | Coverage Δ | | |---|---|---| | [atoMEC/config.py](https://app.codecov.io/gh/atomec-project/atoMEC/pull/200?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=atomec-project#diff-YXRvTUVDL2NvbmZpZy5weQ==) | `100.00% <ø> (ø)` | | | [atoMEC/numerov.py](https://app.codecov.io/gh/atomec-project/atoMEC/pull/200?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=atomec-project#diff-YXRvTUVDL251bWVyb3YucHk=) | `87.44% <96.29%> (-1.06%)` | :arrow_down: | | [atoMEC/convergence.py](https://app.codecov.io/gh/atomec-project/atoMEC/pull/200?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=atomec-project#diff-YXRvTUVDL2NvbnZlcmdlbmNlLnB5) | `100.00% <100.00%> (ø)` | | | [atoMEC/postprocess/conductivity.py](https://app.codecov.io/gh/atomec-project/atoMEC/pull/200?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=atomec-project#diff-YXRvTUVDL3Bvc3Rwcm9jZXNzL2NvbmR1Y3Rpdml0eS5weQ==) | `97.71% <100.00%> (ø)` | | | [atoMEC/postprocess/localization.py](https://app.codecov.io/gh/atomec-project/atoMEC/pull/200?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=atomec-project#diff-YXRvTUVDL3Bvc3Rwcm9jZXNzL2xvY2FsaXphdGlvbi5weQ==) | `93.96% <100.00%> (ø)` | | | [atoMEC/staticKS.py](https://app.codecov.io/gh/atomec-project/atoMEC/pull/200?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=atomec-project#diff-YXRvTUVDL3N0YXRpY0tTLnB5) | `95.43% <100.00%> (ø)` | | | [atoMEC/xc.py](https://app.codecov.io/gh/atomec-project/atoMEC/pull/200?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=atomec-project#diff-YXRvTUVDL3hjLnB5) | `97.65% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.