search

atomic-penguin / cookbook-gitlab-deprecated

Gitlab cookbook
128 stars 84 forks source link

Configure the SSL protocols and ciphers via attributes #117

Closed chewi closed 8 years ago

chewi commented 8 years ago

I would normally use the nginx cookbook's extra_configs attribute for this but the template already specifies these, overriding anything I might put in the global configuration.

While the current cipher list looks reasonable, recent security practices make it important for cookbook users to be able to choose their own cipher list.

epcim commented 8 years ago

@chewi do you consider this PR safe to merge with master. It seems you have spent some time with upgrade to 8.5.x. Anything remaining? How about the gitlab-workhorse you mentioned in other PR?

I am about to merge it as all of the PR are pretty reasonable. Later fix potential issues with Travis etc.

chewi commented 8 years ago

@epcim I believe so. Despite the (only slightly) outdated gitlab-workhorse, we've been using this in production a decent amount this past couple of weeks and haven't seen a single issue. I take it you're talking about all the PRs, not just this one.

chewi commented 8 years ago

Thanks!