search

atomic-penguin / cookbook-gitlab-deprecated

Gitlab cookbook
128 stars 84 forks source link

Added dependencies for rhel based systems and database attribute #118

Closed franznemeth closed 8 years ago

franznemeth commented 8 years ago

Fixed a minor bug for rhel systems where the chef run wouldnt complete because libjemalloc wasnt installed by the cookbook.

chewi commented 8 years ago

Why is jemalloc needed exactly? I'm using CentOS 7 and haven't seen this.

franznemeth commented 8 years ago

On our minimal centos-7 the chef run failed because jemalloc wasnt installed for the ccmake build.

chewi commented 8 years ago

Neither my production server, which was a minimal CentOS 7 install, or my new Kitchen instance, which uses the CentOS 7 Bento box, have jemalloc installed. The former has Ruby 2.1.6 and gitlab 7.13. The latter has Ruby 2.1.8 and gitlab 8.5. I'm not saying this isn't needed, I'd just like to know more about the problem. What versions are you using and where does ccmake come into it because I'm not sure?

franznemeth commented 8 years ago

I am using

I took a closer look at our chef-run. It fails at building the redis server. Should I open an issue in the redisio repo?

chewi commented 8 years ago

Okay, that makes a bit more sense but strange it didn't fail for me. I think you should open the issue there, although I've wondered why we don't just install redis from a package. The cookbook supports a package_install attribute and I considered looking into that but our production server already has it from source and I had other things to be getting on with.

chewi commented 8 years ago

Thinking about it some more, the gitlab cookbook shouldn't care how redis is installed. It should be down to the user whether to set package_install or not.