search

atomic14 / esp32-tv

ESP32 - Sound and Vision - Video Streaming to the ESP32
149 stars 25 forks source link

Show when SD Card fails to mount #21

Closed cgreening closed 4 months ago

cgreening commented 4 months ago

Don't go into an infinite loop when the SD Card fails to mount.

Helps to troubleshoot #19

Summary by CodeRabbit

coderabbitai[bot] commented 4 months ago

Walkthrough

This update introduces a new error handling feature for SD card failures in a media player application. It adds functionality to display error messages on both Matrix and TFT displays when the SD card cannot be mounted. Additionally, the main program logic now includes checks for SD card mounting success, with a fallback to an error state if the mounting fails.

Changes

Files Change Summary
.../Displays/Matrix.cpp, Matrix.h Added drawSDCardFailed() to show an error on Matrix display.
.../Displays/TFT.cpp, TFT.h Added drawSDCardFailed() to show an error on TFT display.
.../main.cpp Enhanced SD card mounting checks; infinite loop on failure.

🐰✨ Oh hoppity hop, in the code we dive deep, A bug in the thicket, makes the system weep. Fear not, for the fix is both clever and grand, With messages clear, on displays they stand. Looping around, in a watchful, endless leap. 🌟 🐇💾

Recent Review Details **Configuration used: CodeRabbit UI**
Commits Files that changed from the base of the PR and between 68bafbda2c0a33302b8b605e63b373aaff0d3282 and 92d38e108b7d7074bdbbe715d37186f8aa7afc7f.
Files selected for processing (5) * player/src/Displays/Matrix.cpp (1 hunks) * player/src/Displays/Matrix.h (1 hunks) * player/src/Displays/TFT.cpp (1 hunks) * player/src/Displays/TFT.h (1 hunks) * player/src/main.cpp (1 hunks)
Additional comments not posted (5)
player/src/Displays/Matrix.h (1)
`21-21`: The addition of `drawSDCardFailed()` to the `Matrix` class is appropriate for handling SD card mount failures.
player/src/Displays/TFT.h (1)
`23-23`: The addition of `drawSDCardFailed()` to the `TFT` class is appropriate for handling SD card mount failures.
player/src/Displays/Matrix.cpp (1)
`55-61`: The implementation of `drawSDCardFailed()` in the `Matrix` class correctly handles the display of the SD card failure message.
player/src/Displays/TFT.cpp (1)
`83-89`: The implementation of `drawSDCardFailed()` in the `TFT` class correctly handles the display of the SD card failure message.
player/src/main.cpp (1)
`74-81`: The changes in the SD card mount check enhance system stability and user feedback by appropriately handling mount failures.
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.