Closed davidhampgonsalves closed 2 months ago
The changes involve modifying the SDCard
constructor in the SDCard.cpp
file. The maximum frequency setting for the SD card interface has been updated from a fixed value of SDMMC_FREQ_52M
to SDMMC_FREQ_DEFAULT
. This change allows for greater flexibility in speed settings, enabling the use of higher speeds if supported by the SD card in use.
File | Change Summary |
---|---|
player/src/SDCard.cpp | Modified SDCard::SDCard constructor to change m_host.max_freq_khz from SDMMC_FREQ_52M to SDMMC_FREQ_DEFAULT . |
(No sequence diagrams generated as the changes are too simple.)
In the land of bytes and bits,
A card spins fast, it never quits.
From fifty-two to default speed,
Our rabbit hearts now dance with glee!
Hopping high, we celebrate,
Flexibility is truly great! 🐇✨
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
As per https://github.com/atomic14/esp32-tv/issues/19 this PR reduces the SD card max frequency to use SDMMC_FREQ_DEFAULT which has been seen to support a wider range of SD cards that might be used.
Summary by CodeRabbit