atomic14 / esp32_audio

Sample code for reading audio samples from the ESP32 ADC using I2S
Creative Commons Zero v1.0 Universal
397 stars 109 forks source link

Typo in i2s sampling's main.cpp leads to wifiClientI2S never being used #4

Closed JRVeale closed 3 years ago

JRVeale commented 3 years ago

In void sendData() I think line 59 should be:

httpClient->begin(*wifiClient, url); previously was httpClient->begin(*wifiClientADC, url);

Not something worth me making a PR for, but thought worth pointing out!

cgreening commented 3 years ago

Good spot! I'll fix this now.

cgreening commented 3 years ago

Fixed by e8a9e282ff3c8176209b757c8486f5d6c8ec1003