search

atomic14 / m5stack-core2-audio-monitor

A fun little project to test out the mic on the M5Stack CORE2
Creative Commons Zero v1.0 Universal
69 stars 17 forks source link

Open to formatting changes? #9

Closed sybrenstuvel closed 1 year ago

sybrenstuvel commented 1 year ago

Hello,

I've made a few changes to the code, and I wouldn't mind sending in a few pull requests. For one, I needed to remove DC offset from the samples before applying the Hamming window. I also have some smaller changes (which I feel are improvements), like reducing indentation level and removing an unnecessary cast.

However, for me to work on the code comfortably, I reformatted the code. In my day job I work on Blender, and it's just more comfortable for me to keep using their C++ code style in my personal projects too (so I don't need to switch). My fork of this repo has all my changes.

The thing is, this project didn't include any formatting configuration, and so my changes to the formatting will make future PRs hard to merge. Would you be willing to copy my formatting changes? Or have any other .clang-format rules that ensure consistent formatting? That would make it significantly easier for me to contribute. It's fine if you say no -- it's only some minor changes, I'm not planning to make this my life's only purpose ;-)

Cheers, Sybren

cgreening commented 1 year ago

Why don't I make a you a contributor to the project?

sybrenstuvel commented 1 year ago

Hah, that would simplify things, yeah :)

sybrenstuvel commented 1 year ago

Thanks for the access! I've pushed my changes to the main branch.