atomicbird / TZLocation

Probably Approximately Correct Location via Time Zone
40 stars 3 forks source link

Please add semantic version tags #1

Open laptobbe opened 10 years ago

laptobbe commented 10 years ago

I’ve recently added TZLocation to the CocoaPods package manager repo.

CocoaPods is a tool for managing dependencies for OSX and iOS Xcode projects and provides a central repository for iOS/OSX libraries. This makes adding libraries to a project and updating them extremely easy and it will help users to resolve dependencies of the libraries they use.

However, TZLocation doesn't have any version tags. I’ve added the current HEAD as version 0.0.1, but a version tag will make dependency resolution much easier.

Semantic version tags (instead of plain commit hashes/revisions) allow for resolution of cross-dependencies.

In case you didn’t know this yet; you can tag the current HEAD as, for instance, version 1.0.0, like so:

$ git tag -a 1.0.0 -m "Tag release 1.0.0"
$ git push --tags
atomicbird commented 10 years ago

Any semantic versioning on this project would need to reference the version info on the IANA timezone database in some way, since it's likely that the project will be updated with no functional changes but with more recent versions of that data. The current version is "2014c". Do you have any thoughts regarding how to incorporate that in a reasonable manner?

laptobbe commented 10 years ago

I did some thinking and I have a suggestion. The project could update the PATCH version for every update to the IANA timezone database and update the MINOR version for every small functional improvement. To include information about the database version you could use an additional tag on the commit that updated the database version.

So the commits could look something like this

What do you think?

nickynick commented 10 years ago

+1 would be much appreciated :+1:

BenjaminDigeon commented 8 years ago

+1 would be appreciated :+1: