atomicdata-dev / atomic-data-browser

This repo is no longer used! Code is moved to Atomic-Server
https://github.com/atomicdata-dev/atomic-server/issues
MIT License
56 stars 9 forks source link

Improved cookie based auth #253

Open joepio opened 1 year ago

joepio commented 1 year ago

Current implementation of cookie based auth #241 solves the most important issue (being able to view private images), but it still needs some improvements:

rescribet commented 1 year ago

Cross origin cookies can't be set from JavaScript by design (major security risico), from what I can see only subdomains are a possibility. Proxying images through your own server seems like an easy solution.

By far the simplest way to invalidate authentication is to set a minimum timestamp and reject everything earlier. Though just adding an expiration is more robust.