atomicdata-dev / atomic-data-browser

This repo is no longer used! Code is moved to Atomic-Server
https://github.com/atomicdata-dev/atomic-server/issues
MIT License
56 stars 9 forks source link

QueryScope should not be sent to the back-end #258

Closed joepio closed 1 year ago

joepio commented 1 year ago

Screenshot 2022-10-28 at 13 55 56

The back-end will not accept query parameters that it does not recognize. This is to help API users discover typos in their requests. Some related discussion on this.

I think the queryScope state should be stored somewhere else.

Or alternatively (perhaps even better), when performing the scoped search action, the user should be navigated to the /search route, and there a query param would be fitting. This also fixes a UX issue, namely that now pressing the search moves focus down, which is kind of hard to spot since the user is looking at the top right.