search

atomicdata-dev / atomic-data-browser

This repo is no longer used! Code is moved to Atomic-Server
https://github.com/atomicdata-dev/atomic-server/issues
MIT License
56 stars 9 forks source link

Upload E2E test not working in this CI #259

Closed joepio closed 1 year ago

joepio commented 1 year ago

For some reason, one specific E2E test has been failing only in the CI of atomic-data-browser.

It's the download, upload test. It works fine locally, and the rust build works fine, too.

322: waiting for selector "[data-test]:has-text("testimage.svg")"

And here the screenshots: ![test-failed-4](https://user-images.githubusercontent.com/2183313/198605366-92e8fa0c-6c6f-45de-a580-ff3fed7309c9.png) ![test-failed-3](https://user-images.githubusercontent.com/2183313/198605380-a306747f-6e60-40d9-b25d-165389d83e87.png) ![test-failed-2](https://user-images.githubusercontent.com/2183313/198605388-44e06927-062e-424d-8c95-bfb0c9586126.png) ![test-failed-1](https://user-images.githubusercontent.com/2183313/198605394-95424be7-e5e6-4392-8f86-aaa0cab547be.png)

Seems like the first screenshot is showing a failed upload, I suspect the cookie not to be sent.

EDIT: has to do with #253. Cookie auth is not working cross origin, which is used when uploading the file.

joepio commented 1 year ago

Yup, turning on signed HTTP requests for uploads fixed the issue. #253 (cross-origin cookies) would fix this.