search

atomiclabs / cryptocurrency-icons-website

Website for the cryptocurrency-icons project
http://cryptoicons.co
Creative Commons Zero v1.0 Universal
67 stars 5 forks source link

Proposing Design Changes to main header window #8

Open theNaut1lus opened 5 years ago

theNaut1lus commented 5 years ago

This website is a wonderful source :)

There are a couple of designs that can be implemented onto the website, which would boost the overall look of the whole website.

  1. We can instead of using primary blue bootstrap colours for the buttons, we could shift to other colours, the blue as of now looks too dated and could be changed.
  2. Instead of featuring only the bitcoin icon logo, we can implemented a script to periodically keep changing the main icon header, as it is we do have all the icons in the repo (for the purpose of displaying them on the page)
  3. We could also update the license at the bottom to point to atomiclabs or to the license.md file of this repo, instead of pointing to a singular developer (low priority)
lukechilds commented 5 years ago

Hi, thanks for your suggestions!

  1. We can instead of using primary blue bootstrap colours for the buttons, we could shift to other colours, the blue as of now looks too dated and could be changed.

I'm open to this, feel free to provide a PR or a mockup.

  1. Instead of featuring only the bitcoin icon logo, we can implemented a script to periodically keep changing the main icon header, as it is we do have all the icons in the repo (for the purpose of displaying them on the page)

That isn't the Bitcoin icon from this icon pack, that's a specific icon for the website.

I think it's better that this website has it's own icon rather than just uses the icons in the icon pack as it's icon.

  1. We could also update the license at the bottom to point to atomiclabs or to the license.md file of this repo, instead of pointing to a singular developer (low priority)

We (@atomiclabs) inherited the cryptocurrency-icons project, but @imnotadeveloper built the demo site. We haven't really made any large contributions to the demo site code, we just split it out into a separate repo and cleaned up a few things. I don't think it would be fair to remove their credit.

If you click on the "License" text it links to the LICENSE.md file in this repo.

Feel free to submit any design changes you want. You can submit them as an issue with a visual mockup, or as a PR with code changes. But please be aware we may not merge them if we don't think they improve the site.

lucaslarroche commented 5 years ago

@lukechilds actually, you can remove the credit 🙂 I did not put it in my PR. It was cjdowner who had added it. Thank you for maintaining this repo.

lukechilds commented 5 years ago

@imnotadeveloper ok thanks.

I'll leave it for now as you're the only contributor, but if we get some more contributions (like from @co16353sidak) we'll remove it and maybe link to the GitHub contributors section instead.

https://github.com/atomiclabs/cryptocurrency-icons-website/graphs/contributors