search

atomiclabs / hyperdex

Grandma-Friendly Atomic Swaps
MIT License
153 stars 56 forks source link

I can create 2 profiles with the same name. that should be avoided #213

Closed ptyx11 closed 6 years ago

ptyx11 commented 6 years ago

HyperDEX Nightly 0.0.0-570351d-18.5.13.937 Electron 2.0.0 darwin 17.5.0 Locale: en-US

lukechilds commented 6 years ago

This is intentional for a number of reasons. We can't stop people using the same name. Even if we put limits on the creation they can edit the portfolio file. And if we completely prevented it, that would prevent users from copying an old backed up portfolio file into the data directory if they already had a portfolio of the same name.

We have made sure that multiple portfolios of the same name will work together without compatibility issues. The name is only metadata, a separate portfolio file will be created for each. They will also each have their own avatar deterministically generated which will help differentiate between an existing portfolio and an imported portfolio of the same name.