search

atomiclabs / hyperdex

Grandma-Friendly Atomic Swaps
MIT License
153 stars 56 forks source link

Several issues with withdrawal #323

Open jdmarlow86 opened 6 years ago

jdmarlow86 commented 6 years ago

Tried to withdrawal BEER, PIZZA, and KMD to Agama

  1. When I exit the withdraw window the balance I entered to withdraw is added back to the total balance suggesting the withdraw never happened (in these cases it doesn't)

  2. Once withdraw is selected (everything seems populated correctly) nothing happens except for the Withdraw button being unselectable. Suggest adding a success or fail msg. image

  3. There is an pre-populated zero in the Amount field allowing numbers to be entered after the zero image

Version: v0.1.0-alpha2 OS: windows Error msgs: no errors were generated in the dev window

lukechilds commented 6 years ago

Thanks for the detailed feedback!

  1. When I exit the withdraw window the balance I entered to withdraw is added back to the total balance suggesting the withdraw never happened (in these cases it doesn't)

It sounds like this is working correctly if the balance didn't withdraw. Or are you saying it also does this for successful withdrawals?

  1. Once withdraw is selected (everything seems populated correctly) nothing happens except for the Withdraw button being unselectable. Suggest adding a success or fail msg.

This is because we're waiting for marketmaker. There are two steps to a withdrawal. Creating a TX (which you were waiting for) so we can show you the final fee. And then broadcasting the TX. Once mm has created the TX we will show you the fee and the button will no longer be greyed out and will ask for confirmation.

This is how it's supposed to work:

The issues you are experiencing are purely due to extremely slow responses from marketmaker. Nothing to do with the GUI.

Maybe we should add some extra text like "Calculating txfee..." if marketmaker hasn't responded after a certain amount of time. Just to make it clearer we're waiting for something to happen.

3 There is an pre-populated zero in the Amount field allowing numbers to be entered after the zero

This looks like a known React bug. @sindresorhus has added a workaround for some of the other fields. Is this the same issue @sindresorhus?

jdmarlow86 commented 6 years ago

Thanks @lukechilds - you're right on number one, it doesn't complete the tx so that makes sense. For number two a message definitely helps but mm isn't suppose to take this long is it? I started another withdraw about 30 minutes ago and it's still creating the tx

jdmarlow86 commented 6 years ago

Number 2 (withdraw button is stuck) seems to be ok now, extra text is a good enhancement if it is expected to reoccur. Thanks!

lukechilds commented 6 years ago

mm isn't suppose to take this long is it?

Unfortunately we've experienced all sorts of crazy edge cases with how long it takes mm to respond. If we don't get an error response and we're just waiting for a reply we really have no idea what's going on on the other side.

I started another withdraw about 30 minutes ago and it's still creating the tx

I've not experience delays that long. You can open the network tab in dev tools and see what's going on. If the request says pending then it's waiting for a response from mm. Can you let me know if you can recreate this and we can look into it.

Number 2 (withdraw button is stuck) seems to be ok now, extra text is a good enhancement if it is expected to reoccur. Thanks!

We haven't changed anything on our end. Will look at adding extra text to try and avoid confusion.