atomiclabs / hyperdex

Grandma-Friendly Atomic Swaps
MIT License
153 stars 56 forks source link

BEER coin disappeared #574

Closed osyed closed 5 years ago

osyed commented 5 years ago

Describe the bug

I was testing out Hyperdex. I added and removed another coin and it caused Beer coin to disappear from my portfolio.

To reproduce

  1. Go to Settings tab.
  2. Under "Enabled currencies" click on drop down to add a new one.
  3. Under "Enabled currencies" click on X to delete the one you just added.
  4. Go to Dashboard. Beer used to be listed above Bitcoin and Komodo, but now it is gone. It is not listed under "Enabled currencies" drop down either.

System info

Additional context

Even reinstalling Hyperdex and restoring the account does not bring back Beer coin.

sindresorhus commented 5 years ago

BEER is only meant for testing, so we've only enabled during development and in nightly releases.

osyed commented 5 years ago

Well it was there when I started the HyperDex program. I was able to use the BEER address and receive coins from the faucet. I was also able to create an open order to convert BEER to PIZZA. It just disappeared after I added a new coin and deleted it.

sindresorhus commented 5 years ago

We filter the BEER currency (based on whether you're running in debug mode or not) when you add/remove a currency. That's why it suddenly disappeared. You probably previously ran a much older HyperDEX version, a nightly build, or HyperDEX in debug-mode, and that's why you had the BEER currency enabled. If you really want it back, go to "Help" in the top menu and click "Debug Mode", then you'll be able to enable BEER again.

osyed commented 5 years ago

Thanks. I was able to enable BEER again. I would say, don't bother trying to filter is based on status of debug mode and checking that when a currency is being added/removed. Just let the user disable it if they want. It will avoid customer service issues.