search

atomiclabs / hyperdex

Grandma-Friendly Atomic Swaps
MIT License
152 stars 60 forks source link

Add Denarius (D) currency #597

Closed metaspartan closed 5 years ago

metaspartan commented 5 years ago

Adds back Denarius (D) Support to HyperDEX

PR for Cryptocurrency Icons to update namings from DNR to D: https://github.com/atomiclabs/cryptocurrency-icons/pull/295

PR for jl777 coins repo, already merged: https://github.com/jl777/coins/pull/276

sindresorhus commented 5 years ago

DNR electrums were run by the coin owner, but not maintained, so they were causing problems - https://github.com/atomiclabs/hyperdex/pull/577#issuecomment-445567840

What guarantees do we have that this won't happen again?

Please also read and adhere to https://github.com/atomiclabs/hyperdex/blob/master/docs/add-currency.md (Read it thoroughly)

metaspartan commented 5 years ago

DNR electrums were run by the coin owner, but not maintained, so they were causing problems

What guarantees do we have that this won't happen again?

Please also read and adhere to https://github.com/atomiclabs/hyperdex/blob/master/docs/add-currency.md (Read it thoroughly)

Two of the electrums are ran by a team mate now and I am running the third, they are hosted on a better platform now as well for all of them. We want Denarius on the HyperDEX, there was communication issues before due to you guys moving from Slack and myself leaving due to the Slack exploits. We are all on Discord now for easier communication.

buzzkillb commented 5 years ago

I will be running some of the servers, so its not just falling on carsen this time. They will be kept up.

lukechilds commented 5 years ago

This looks good to me.

@sindresorhus is there anything you spot missing from https://github.com/atomiclabs/hyperdex/blob/master/docs/add-currency.md ?

sindresorhus commented 5 years ago

The servers should available on domains/subdomains, not IP addresses.

sindresorhus commented 5 years ago

The title of the pull request should be Add Name (SYMBOL) currency. For example, Add FooCoin (FOO) currency.

lukechilds commented 5 years ago

@carsenk @buzzkillb whichever of you runs 51.158.98.28 can you put a domain in front of it?

Should help reduce downtime in the event that you need to change servers or for some other reason lose access to that IP.

metaspartan commented 5 years ago

@lukechilds

I pointed denariuspool.info and electrum.denariuspool.info to 51.158.98.28

It will take awhile for DNS propogation

metaspartan commented 5 years ago

Also denarius.vip and electrum.denarius.vip will be pointed to 51.158.98.28 and eventually a forth server