Can't create project with npm init @atomico

atomicojs / atomico

Atomico a micro-library for creating webcomponents using only functions, hooks and virtual-dom.

https://atomicojs.dev

MIT License

1.16k stars 43 forks source link

Can't create project with npm init @atomico #12

Closed threeid closed 5 years ago

threeid commented 5 years ago

Hello UpperCod,

I can't initialize project with npm init MacOS: 10.14.5 Node: v12.5.0

Maybe there is a way to create atomico app with something like create-atomico-app with both npm and yarn like create react app or vue init?

I would like to contribute. Do you have any direction for me?

threeid commented 5 years ago

Because of function mkdirpath in package template-folder.

https://nodejs.org/api/fs.html#fs_fs_mkdir_path_options_callback Why do you implement mkdir recursively while fs.mkdir already did that and default mode is also 0o777, (you has 0777 in the code)

Use fs.mkdir works!

But why template-folder depends on itself?

"dependencies": {
        "mustache": "^3.0.1",
        "template-folder": "^1.2.0"
    }

UpperCod commented 5 years ago

Hi! @threeid thanks for your issue, I apologize for the error 🙇, now I have generated a maintenance on template-folder and I generated an update on @atomico/create.

The problem is that I am not a mac user to check the result of these changes, I hope your confirmation if the process has been successfully completed.

All help is welcome 👍

threeid commented 5 years ago

It works now. Thanks!