search

atomicojs / atomico

Atomico a micro-library for creating webcomponents using only functions, hooks and virtual-dom.
https://atomicojs.dev
MIT License
1.15k stars 43 forks source link

fix: quote glob patterns in npm script #76

Closed ofhouse closed 2 years ago

ofhouse commented 2 years ago

Hi, while running the tests I noticed that on my machine (MacOS 12.3.1, zsh shell) not all tests were executed.

This happens because my shell environment expands the glob pattern before passing it to the command, resulting in a faulty behaviour. To ensure that the pattern is passed as string to the command, it is therefore a good idea to quote the glob pattern. More info here: https://medium.com/@jakubsynowiec/you-should-always-quote-your-globs-in-npm-scripts-621887a2a784

PS: I used escaped double quotes (\") instead of single quotes (') because someone mentioned that only double quotes would be compatible with Windows (not tested).

UpperCod commented 2 years ago

Thanks for fixing that bug, I appreciate your contribution and I will be attentive to what you need

I invite you to join Discord https://discord.gg/7z3rNhmkNE