search

atomicojs / atomico

Atomico a micro-library for creating webcomponents using only functions, hooks and virtual-dom.
https://atomicojs.dev
MIT License
1.15k stars 43 forks source link

Add support for function components #95

Closed efoken closed 1 year ago

efoken commented 1 year ago

I added the check below let raw to avoid checking type.prototype instanceof HTMLElement twice. So when it is not an instance of HTMLElement raw equals false.

TypeScript for component props in JSX is already working without any changes 😄

UpperCod commented 1 year ago

Thanks for your PR, that looks great! we just need to add some tests and we'd be ready for release🚀

efoken commented 1 year ago

Okay, I added one test in render.test.js, do we need more?

UpperCod commented 1 year ago

that will be enough

efoken commented 1 year ago

@UpperCod can you merge this? I would like to use this for work, we are currently building a complex DatePicker package, so this would be useful 🙂

UpperCod commented 1 year ago

I will release it today, so you can try it tomorrow