search

atomify / atomify-css

Atomic CSS - Reusable front-end styling using Rework, plugins, and Node's resolve algorithm
MIT License
78 stars 18 forks source link

Apply custom rework plugins only if they don't match the current ones. #35

Closed lvivski closed 9 years ago

bclinkinbeard commented 10 years ago

The code looks good but I don't quite understand the scenario. How would you end up with custom plugins that don't pass that conditional?

lvivski commented 10 years ago

Currently it applies the same plugins twice for your files, so a lot of plugins fail on the first pass (myth, rework-calc). And if you have rework-calc, for ex., it will be applied during the prefilter, it will fail on vars (already have a pull-request for that), than vars, assets; and the same plugin list would be applied to this file again during normal phase. So it actually serves two purposes:

  1. Do not apply the same plugin list on the file twice.
  2. Do not apply plugins that are not actually custom.
bclinkinbeard commented 9 years ago

@joeybaker I think this makes sense, can you take a look?

joeybaker commented 9 years ago

Will do. Current status: trying to figure out why my new watch test never completes in travis :( https://travis-ci.org/atomify/atomify-js/jobs/40797798

joeybaker commented 9 years ago

@lvivski thanks for the PR! I just have the comment above, and a request: can you add a test for this?

joeybaker commented 9 years ago

@lvivski unfortunately this isn't mergable, anymore. Do you have any interest in updating it?

lvivski commented 9 years ago

Closed. The issue was caused by myth.io, but since autoprefixer support was added into atomify-css everything is ok now.