search

atomikos / transactions-essentials

Development repository for next major release of
https://www.atomikos.com/Main/TransactionsEssentials
Other
462 stars 139 forks source link

Request to register should not be a WARNING #181

Closed lfb0801 closed 6 months ago

lfb0801 commented 1 year ago

Atomikos suggests to register your download to get advanced features and professional support. It is a good thing to offer these features, but the loglevel should not be warning, because not registering doesn't cause any problems with the working of Atomikos.

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

GuyPardon commented 1 year ago

Thanks for contributing, much appreciated!

Registration is meant to make people aware of the many issues that were fixed since they downloaded. So in a sense it can cause problems if you don't register.

So I have mixed feelings about incorporating this change right now. It's not just a warning but also goes to System.out... It's easy to disable this by registering and setting the property afterwards.

What do you think?

lfb0801 commented 1 year ago

Always happy to help!

The following is a table I found that describes my view of the log levels:

Level Value Description
OFF 0 No logging
FATAL 100 The application is unusable. Action needs to be taken immediately.
ERROR 200 An error occurred in the application.
WARN 300 Something unexpected—though not necessarily an error—happened and needs to be watched.
INFO 400 A normal, expected, relevant event happened.
DEBUG 500 Used for debugging purposes
TRACE 600 Used for debugging purposes—includes the most detailed information

From my point of view, not being registered is not unexpected but it is undesired. So initially I would have suggested to move it to Info, but after listening to your point:

"make people aware of the many issues that were fixed"

Isn't that what release notes are for? 🤔

Would motivate me to move it even lower to debug, as I would only require the registration if I'm debugging an issue. My main motivation for registering would be to get rid of the log-message, not to get any of the additional support or information that you are talking about.