search

atomikos / transactions-essentials

Development repository for next major release of
https://www.atomikos.com/Main/TransactionsEssentials
Other
461 stars 139 forks source link

Support for Feign and FeignClients #191

Closed joshuapullin closed 1 year ago

joshuapullin commented 1 year ago

Has anyone got this working with Feign and FeignClients?

I am using Spring Boot and the current Spring support in transactions-remoting doesn't seem to support Feign (through Spring).

I have tried adding the interceptors via config and exceptions get thrown due to the different class types required. I was just wondering if this is something someone has a working solution for or if there is any support for this coming in the future?

Spring Cloud OpenFeign is heavily used through the APIs so would prefer to keep this functionality in place to reduce the amount of rework required.

GuyPardon commented 1 year ago

Sorry, only noticed this just now. Care to comment on why it is completed?

joshuapullin commented 1 year ago

Adding a custom RequestInterceptor and ResponseInterceptor was needed for the Feign clients.

GuyPardon commented 1 year ago

Got it. Did you consider contributing the code for those?

joshuapullin commented 1 year ago

I haven't finalised the development yet as it is for the company I work for. If I get time once complete, I might try to.

GuyPardon commented 1 year ago

OK thanks let me know...

Moline-x commented 1 week ago

Adding a custom RequestInterceptor and ResponseInterceptor was needed for the Feign clients.

Hi @joshuapullin , may I know how you implement code for this , because I also met issues when executing atomikos and feign client