search

atomikpanda / libcolorpicker

Color Picker Library For iOS
MIT License
38 stars 18 forks source link

miscellaneous bug fixes and improvements #19

Open brendonjkding opened 3 years ago

brendonjkding commented 3 years ago

I love this library a lot, but I heard from Readme of Alderis's repo that this library was abandoned. Sorry to hear that. If anyone still wants to use this library. I highly recommend to statically link with my fork version.

Statically linking to your tweak, so it won't conflict with Alderis. And my fork including miscellaneous bug fixes and improvements listed as below:

If needed , I'm willing to create PRs or directly maintain this library. Thanks, I really love this library.

Nosskirneh commented 3 years ago

Sorry about the late reply. I’ll talk to @atomikpanda and get back to you.

Nosskirneh commented 3 years ago

Also, I’m glad to hear you like the library, and that you turned on ARC completely – I did this a while ago but ended up with issues (some firmware had trouble). The change was then reverted for those files. Do you have tested this on a set of (old) devices? Alderis might be new but it does not come with support for older versions unless I’m mistaken.

brendonjkding commented 3 years ago

Thanks for reply. One of the reason I like this library is it provides great compatibility to old devices.

I have tested on iOS7 but not on iOS10. After some debugging, I think issues on iOS10 should be fixed after this commit I pushed just now https://github.com/brendonjkding/libcolorpicker/commit/dd0a7e0a934505e3d1d3bd9292873b259d87f50c

Now it works without issues on my 32bit iOS7 iPad2 and 32bit iOS10 iPad4. Let me know if issues still exists.

Nosskirneh commented 3 years ago

Nice! I'll give it a try as well on my iOS 10 device. Feel free to open PRs and I'll try to take a look at them and push new versions as necessary.