search

atomiks / tippyjs

Tooltip, popover, dropdown, and menu library
https://atomiks.github.io/tippyjs/
MIT License
11.91k stars 518 forks source link

Update `appendTo` docs to be inline with code/other docs #1026

Open jasikpark opened 2 years ago

jasikpark commented 2 years ago

https://github.com/atomiks/tippyjs/blob/60aee16c934fc861569f84a37c6a1a7f42a33fa0/src/constants.ts#L12

This is a docs change to update the description of the default setting for appendTo

atomiks commented 2 years ago

The current docs are correct as the condition is "If interactive: true"

jasikpark commented 2 years ago

Oh! I didn't see that at all 😅 It looked like the default in the text and the default in the example code described two different defaults

atomiks commented 2 years ago

Yeah tbh the wording could be better. Like describe the actual default, then the default with the condition.

jasikpark commented 2 years ago

I'll update my PR w/ that wording if that works! That seems like a good way to make it less confusing to me :)

jasikpark commented 2 years ago

Only took me 7mo to update 😅

jasikpark commented 1 year ago

anything i can do to push this PR to being merged?