search

atomiks / tippyjs

Tooltip, popover, dropdown, and menu library
https://atomiks.github.io/tippyjs/
MIT License
11.86k stars 520 forks source link

npm install fail #1037

Closed lyz810 closed 2 years ago

lyz810 commented 2 years ago

Bug description

dependency @popperjs/core publish a new version and has a bug, cause tippyjs install fail

The package @popperjs/core@2.11.3 meta data in https://registry.npmjs.org/@popperjs%2fcore has a postinstall, which in previous version is _postinstall, so after install the package, it will try to execute husky install .config/husky

Reproduction

npm i tippy.js or npm i @popperjs/core

npm ERR! command failed
npm ERR! command sh -c husky install .config/husky
npm ERR! sh: husky: command not found

I know this bug belongs to @popperjs/core, but it seems to be moved from github, I don't known where to report this issue

I think this issue should be reported to @FezVrasta or @atomiks

atomiks commented 2 years ago

The package.json of v2.11.3 still has a _ in front of the postinstall though. How does the metadata not have it? I also can't reproduce it myself. Do you have Husky installed?

@FezVrasta has to locally publish npm packages for now as they aren't automated with the new branch setup we have unfortunately.

atomiks commented 2 years ago

This was fixed in latest v