search

atomiks / tippyjs

Tooltip, popover, dropdown, and menu library
https://atomiks.github.io/tippyjs/
MIT License
11.86k stars 520 forks source link

fix merging modifiers #1042

Closed ccpu closed 2 years ago

ccpu commented 2 years ago

In tippy, modifiers used in the code cannot be modified or overridden. I tried to modify the preventOverflow modifier, but it didn't work, so I added a few lines of code to merge the modifiers.

atomiks commented 2 years ago

It works fine though?: https://codepen.io/atomiks/pen/yvwQyZ

atomiks commented 2 years ago

Note: Popper performs merging of modifiers for us, which is why it works. See: https://popper.js.org/docs/v2/faq/#how-do-i-set-modifier-defaults-and-allow-them-to-be-overridden

ccpu commented 2 years ago

I do apologize, been using old version on my app, it does work indeed.