delegate: Don't process event for non Element targets.

atomiks / tippyjs

Tooltip, popover, dropdown, and menu library

https://atomiks.github.io/tippyjs/

MIT License

11.78k stars 517 forks source link

delegate: Don't process event for non Element targets. #1166

Open amanagr opened 2 months ago

amanagr commented 2 months ago

In Firefox, event targets can be pseudo elements like text nodes which don't have .closest method. This results in error when delegate tries to handle trigger for a text node target.

ojaha065 commented 1 month ago

We're a seeing this error a lot lately. Would be nice to have this merged and new version released. Sad to see this project abandoned

timabbott commented 1 week ago

@atomiks any chance you can merge this PR? Even if you don't do a release, it'd be very helpful for us to be able to install a merged upstream commit for get rid of the spammy exception that this fixes.