ensure singleton cleans up previous instances when updated

atomiks / tippyjs

Tooltip, popover, dropdown, and menu library

https://atomiks.github.io/tippyjs/

MIT License

11.91k stars 518 forks source link

ensure singleton cleans up previous instances when updated #993

Closed frankwallis closed 2 years ago

frankwallis commented 2 years ago

This is a fix for an issue where the singleton's target instances get updated. The current behaviour causes their setProps method to get repeatedly wrapped. In my scenario with 1000 target instances it was causing the browser to lock up for several seconds.

Thanks for all your work!

atomiks commented 2 years ago

Thanks!