atomist-attic / rug

DEPRECATED Runtime for Rugs
GNU General Public License v3.0
53 stars 13 forks source link

Add types to Gherkin well-known steps #577

Closed ddgenome closed 7 years ago

ddgenome commented 7 years ago

Add types to callback signatures of TypeScript implementations of the Gherkin well-known steps for projects and handlers. This uncovered a few errors, including:

Using specific types for the world parameter was preferred to using the more generic, e.g., CommandHandlerScenarioWorld was used preferentially to ScenarioWorld where possible.

Consistent names for the project and world callback arguments.

Closes #574

Add copyright and license information.

Import from specific files rather than mode/Core.

Include step name in unimplemented error, see #570.

kipz commented 7 years ago

LGTM